Skip to content

drivers: i2s: stm32_sai add support for stm32l4xx series #95021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 5, 2025
Merged

drivers: i2s: stm32_sai add support for stm32l4xx series #95021

merged 3 commits into from
Sep 5, 2025

Conversation

@mariopaja
Copy link
Contributor

@mariopaja mariopaja commented Aug 26, 2025 •
edited
Loading

This PR enables SAI on STM32L4xx series by:

  1. Adding SAI1 A/B nodes
  2. Update DMA & SAI configurations for STM32L4xx
  3. Adding nucleo_l432kc in samples/drivers/i2s/output
stm32l4xx_sai

@mariopaja mariopaja mentioned this pull request Aug 26, 2025
Open
23 tasks
evgeniy-paltsev
evgeniy-paltsev requested changes Aug 27, 2025
View reviewed changes
@evgeniy-paltsev
Copy link
Contributor

evgeniy-paltsev commented Aug 27, 2025 •
edited
Loading

Logs from my side:

Could not trigger I2S tx
[00:00:00.000,000] <dbg> i2s_stm32_sai: stm32_sai_enable_clock: Clock Control Device: <OK>
[00:00:00.000,000] <dbg> i2s_stm32_sai: stm32_sai_enable_clock: I2S clock Enable: <OK>
[00:00:00.000,000] <dbg> i2s_stm32_sai: stm32_sai_enable_clock: I2S domain clock configuration: <OK>
[00:00:00.000,000] <inf> i2s_stm32_sai: sai1@40015404 inited
*** Booting Zephyr OS build v4.2.0-rc2-2503-g4e322a40c201 ***
[00:00:00.000,000] <dbg> i2s_stm32_sai: i2s_stm32_sai_configure: SAI_STEREOMODE
[00:00:00.000,000] <dbg> i2s_stm32_sai: i2s_stm32_sai_trigger: I2S_TRIGGER_START
[00:00:01.001,000] <err> i2s_stm32_sai: HAL_SAI_Transmit_DMA: <FAILED>
[00:00:01.001,000] <err> i2s_stm32_sai: START trigger failed -5

We stuck waiting for this:

    /* Wait until FIFO is not empty */
    while ((hsai->Instance->SR & SAI_xSR_FLVL) == SAI_FIFOSTATUS_EMPTY)

@evgeniy-paltsev
Copy link
Contributor

evgeniy-paltsev commented Aug 27, 2025 •
edited
Loading

Instance seems to be correct (DMA2_Channel1)
Request number (DMA_REQUEST_1) seems to be correct.
DMA2_CSELR->CSELR == 1 - seems to be correct.

As I understand dma_slot = 37 from dmas = <&dma2 1 37 (STM32_DMA_MODE_NORMAL | STM32_DMA_PRIORITY_HIGH | is not really affect any HW configuration (in case of current L4 code).

evgeniy-paltsev
evgeniy-paltsev requested changes Aug 27, 2025
View reviewed changes
@mariopaja
Copy link
Contributor Author

mariopaja commented Aug 27, 2025 •
edited
Loading

Logs from my side:

Could not trigger I2S tx
[00:00:00.000,000] <dbg> i2s_stm32_sai: stm32_sai_enable_clock: Clock Control Device: <OK>
[00:00:00.000,000] <dbg> i2s_stm32_sai: stm32_sai_enable_clock: I2S clock Enable: <OK>
[00:00:00.000,000] <dbg> i2s_stm32_sai: stm32_sai_enable_clock: I2S domain clock configuration: <OK>
[00:00:00.000,000] <inf> i2s_stm32_sai: sai1@40015404 inited
*** Booting Zephyr OS build v4.2.0-rc2-2503-g4e322a40c201 ***
[00:00:00.000,000] <dbg> i2s_stm32_sai: i2s_stm32_sai_configure: SAI_STEREOMODE
[00:00:00.000,000] <dbg> i2s_stm32_sai: i2s_stm32_sai_trigger: I2S_TRIGGER_START
[00:00:01.001,000] <err> i2s_stm32_sai: HAL_SAI_Transmit_DMA: <FAILED>
[00:00:01.001,000] <err> i2s_stm32_sai: START trigger failed -5

We stuck waiting for this:

    /* Wait until FIFO is not empty */
    while ((hsai->Instance->SR & SAI_xSR_FLVL) == SAI_FIFOSTATUS_EMPTY)

This is the same behaviour that I also get

Instance seems to be correct (DMA2_Channel1) Request number (DMA_REQUEST_1) seems to be correct. DMA2_CSELR->CSELR == 1 - seems to be correct.

As I understand dma_slot = 37 from dmas = <&dma2 1 37 (STM32_DMA_MODE_NORMAL | STM32_DMA_PRIORITY_HIGH | is not really affect any HW configuration (in case of current L4 code).

dma_slot = 37 is an arbitrary number set by me, but as you said it has no affect to the DMA configuration. To tell the truth I dont know why dma_slot is required in the binding, or why it is implemented at the first place.

However dma_cfg.dma_slot return 0x25 and I dont know where this value comes from, this is the reason why I am setting the request number to DMA_REQUEST_1

evgeniy-paltsev
evgeniy-paltsev requested changes Aug 27, 2025
View reviewed changes
@evgeniy-paltsev
Copy link
Contributor

evgeniy-paltsev commented Aug 27, 2025

Now I have

[00:00:30.002,000] <dbg> i2s_stm32_sai: i2s_stm32_sai_trigger: I2S_TRIGGER_DRAIN
[00:00:00.000,000] <dbg> i2s_stm32_sai: stm32_sai_enable_clock: Clock Control Device: <OK>
[00:00:00.000,000] <dbg> i2s_stm32_sai: stm32_sai_enable_clock: I2S clock Enable: <OK>
[00:00:00.000,000] <dbg> i2s_stm32_sai: stm32_sai_enable_clock: I2S domain clock configuration: <OK>
[00:00:00.000,000] <inf> i2s_stm32_sai: sai1@40015404 inited
*** Booting Zephyr OS build v4.2.0-rc2-2503-g4e322a40c201 ***
[00:00:00.000,000] <dbg> i2s_stm32_sai: i2s_stm32_sai_configure: dma_src_size 2
[00:00:00.000,000] <dbg> i2s_stm32_sai: i2s_stm32_sai_configure: SAI_STEREOMODE
[00:00:00.000,000] <dbg> i2s_stm32_sai: i2s_stm32_sai_trigger: I2S_TRIGGER_START
[00:00:02.001,000] <err> i2s_stm32_sai: TX queue full
[00:00:04.001,000] <err> i2s_stm32_sai: TX queue full
[00:00:06.001,000] <err> i2s_stm32_sai: TX queue full
[00:00:08.001,000] <err> i2s_stm32_sai: TX queue full
[00:00:10.001,000] <err> i2s_stm32_sai: TX queue full
[00:00:12.001,000] <err> i2s_stm32_sai: TX queue full
[00:00:14.001,000] <err> i2s_stm32_sai: TX queue full
[00:00:16.001,000] <err> i2s_stm32_sai: TX queue full
[00:00:18.001,000] <err> i2s_stm32_sai: TX queue full
[00:00:20.002,000] <err> i2s_stm32_sai: TX queue full
[00:00:22.002,000] <err> i2s_stm32_sai: TX queue full
[00:00:24.002,000] <err> i2s_stm32_sai: TX queue full
[00:00:26.002,000] <err> i2s_stm32_sai: TX queue full
[00:00:28.002,000] <err> i2s_stm32_sai: TX queue full
All I2S blocks written
[00:00:30.002,000] <err> i2s_stm32_sai: TX queue full
[00:00:30.002,000] <dbg> i2s_stm32_sai: i2s_stm32_sai_trigger: I2S_TRIGGER_DRAIN

@mariopaja
Copy link
Contributor Author

mariopaja commented Aug 28, 2025

Now I have

[00:00:30.002,000] <dbg> i2s_stm32_sai: i2s_stm32_sai_trigger: I2S_TRIGGER_DRAIN
[00:00:00.000,000] <dbg> i2s_stm32_sai: stm32_sai_enable_clock: Clock Control Device: <OK>
[00:00:00.000,000] <dbg> i2s_stm32_sai: stm32_sai_enable_clock: I2S clock Enable: <OK>
[00:00:00.000,000] <dbg> i2s_stm32_sai: stm32_sai_enable_clock: I2S domain clock configuration: <OK>
[00:00:00.000,000] <inf> i2s_stm32_sai: sai1@40015404 inited
*** Booting Zephyr OS build v4.2.0-rc2-2503-g4e322a40c201 ***
[00:00:00.000,000] <dbg> i2s_stm32_sai: i2s_stm32_sai_configure: dma_src_size 2
[00:00:00.000,000] <dbg> i2s_stm32_sai: i2s_stm32_sai_configure: SAI_STEREOMODE
[00:00:00.000,000] <dbg> i2s_stm32_sai: i2s_stm32_sai_trigger: I2S_TRIGGER_START
[00:00:02.001,000] <err> i2s_stm32_sai: TX queue full
[00:00:04.001,000] <err> i2s_stm32_sai: TX queue full
[00:00:06.001,000] <err> i2s_stm32_sai: TX queue full
[00:00:08.001,000] <err> i2s_stm32_sai: TX queue full
[00:00:10.001,000] <err> i2s_stm32_sai: TX queue full
[00:00:12.001,000] <err> i2s_stm32_sai: TX queue full
[00:00:14.001,000] <err> i2s_stm32_sai: TX queue full
[00:00:16.001,000] <err> i2s_stm32_sai: TX queue full
[00:00:18.001,000] <err> i2s_stm32_sai: TX queue full
[00:00:20.002,000] <err> i2s_stm32_sai: TX queue full
[00:00:22.002,000] <err> i2s_stm32_sai: TX queue full
[00:00:24.002,000] <err> i2s_stm32_sai: TX queue full
[00:00:26.002,000] <err> i2s_stm32_sai: TX queue full
[00:00:28.002,000] <err> i2s_stm32_sai: TX queue full
All I2S blocks written
[00:00:30.002,000] <err> i2s_stm32_sai: TX queue full
[00:00:30.002,000] <dbg> i2s_stm32_sai: i2s_stm32_sai_trigger: I2S_TRIGGER_DRAIN

From an inital look without going into details seems like HAL_SAI_TxCpltCallback() is not called. I will have a look into it 😄

@mariopaja mariopaja force-pushed the stm32l4_sai branch 5 times, most recently from 53efd8a to f195c5b Compare August 29, 2025 12:16
@mariopaja
Copy link
Contributor Author

mariopaja commented Aug 29, 2025

@evgeniy-paltsev Issue found, SAI should work now without problems

The issue was DMA Channel.

On STM32L4xx DMA channel is given from 0 - 7
On other platforms DMA channel given is given from 1 - 8

@evgeniy-paltsev
Copy link
Contributor

evgeniy-paltsev commented Aug 29, 2025

Haven't tried to connect real I2S peripheral yet - but at least DMA seems to be working now :)

evgeniy-paltsev
evgeniy-paltsev requested changes Aug 29, 2025
View reviewed changes
Copy link
Contributor

@evgeniy-paltsev evgeniy-paltsev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dma_slot = 37 is an arbitrary number set by me, but as you said it has no affect to the DMA configuration. To tell the truth I dont know why dma_slot is required in the binding, or why it is implemented at the first place.

However dma_cfg.dma_slot return 0x25 and I dont know where this value comes from, this is the reason why I am setting the request number to DMA_REQUEST_1

IMO, that's quite simple. We just need to use request number in slot field in dts.

Proof: https://github.com/zephyrproject-rtos/zephyr/blob/main/dts/bindings/dma/st%2Cstm32-dma-v2.yaml#L16

@evgeniy-paltsev
Copy link
Contributor

evgeniy-paltsev commented Aug 29, 2025

It's alive :)
image

However I see another issue now. We put stream in I2S_STATE_STOPPING state - but we never turn HW off - so SAI just keep working and generate FS and CLK (with data = 0).

You can check other I2S drivers (i.e. i2s_ll_stm32.c) - they turn hardware off when transmit is finished.

@mariopaja
Copy link
Contributor Author

mariopaja commented Aug 29, 2025

@evgeniy-paltsev

You can check other I2S drivers (i.e. i2s_ll_stm32.c) - they turn hardware off when transmit is finished.

I wrote it down. I will check it and open a dedicated PR for that 😄

Since there are two issues with the H7 DMA I will open a new PR:

hdma->Init.PeriphInc = DMA_PINC_DISABLE;
hdma->Init.MemInc = DMA_MINC_ENABLE;

hdma->Init.MemDataAlignment = DMA_MDATAALIGN_HALFWORD;

@mariopaja mariopaja force-pushed the stm32l4_sai branch 8 times, most recently from dba4b52 to 3bf0129 Compare September 3, 2025 12:56
@mariopaja mariopaja marked this pull request as ready for review September 3, 2025 13:03
@zephyrbot zephyrbot added area: Samples Samples platform: STM32 ST Micro STM32 labels Sep 3, 2025
@anangl anangl assigned erwango and unassigned anangl Sep 3, 2025
etienne-lms
etienne-lms reviewed Sep 3, 2025
View reviewed changes
Copy link
Contributor

@etienne-lms etienne-lms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside some minor issues.

dts/arm/st/l4/stm32l4.dtsi Outdated
#address-cells = <1>;
#size-cells = <0>;
reg = <0x40015404 0x20>;
clocks = <&rcc STM32_CLOCK(APB2, 21U)>,
Copy link
Contributor

@etienne-lms etienne-lms Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency in STM32 SoCs DTSI files (be kind my @mathieuchopstm, see #93912):

Suggested change
clocks = <&rcc STM32_CLOCK(APB2, 21U)>,
clocks = <&rcc STM32_CLOCK(APB2, 21)>,

Ditto for sai1_b below.

drivers/i2s/i2s_stm32_sai.c Outdated
return -EINVAL;
}

/* STM32L4xx not possible to control MCLK output from SAI configuration */
Copy link
Contributor

@etienne-lms etienne-lms Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/* STM32L4xx not possible to control MCLK output from SAI configuration */
/* Control of MCLK output from SAI configuration is not possible on STM32L4xx MCUs */

drivers/i2s/i2s_stm32_sai.c Outdated
4);

DT_INST_FOREACH_STATUS_OKAY(I2S_STM32_SAI_INIT)
DT_INST_FOREACH_STATUS_OKAY(I2S_STM32_SAI_INIT)
Copy link
Contributor

@etienne-lms etienne-lms Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please discard this change straight from commit "drivers: i2s: i2s_stm32_sai add support for stm32l4xx".

dts/arm/st/l4/stm32l4.dtsi Outdated
Comment on lines 579 to 580
dmas = <&dma2 1 1 (STM32_DMA_MODE_NORMAL | STM32_DMA_PRIORITY_HIGH |
STM32_DMA_16BITS)>;
Copy link
Contributor

@etienne-lms etienne-lms Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking on indentation. Would be better as:

		dmas = <&dma2 1 1 (STM32_DMA_MODE_NORMAL | STM32_DMA_PRIORITY_HIGH |
				   STM32_DMA_16BITS)>;

@mariopaja
dts: st: l4: add sai1 node
093daed 
Add SAI1 A & B nodes for STM32L4xx series

Signed-off-by: Mario Paja <mariopaja@hotmail.com>
@mariopaja
drivers: i2s: i2s_stm32_sai add support for stm32l4xx
f1a9592 
STM32L4xx series shares several SAI & DMA configurations with
the other platforms. These changes aim to remove specific
DMA & SAI configurations which are not used by STM32L4xx

Signed-off-by: Mario Paja <mariopaja@hotmail.com>
@mariopaja
samples: i2s: output: add nucleo_l432kc
53d39a3 
Add nucleo_l432kc in samples/drivers/i2s/output

Signed-off-by: Mario Paja <mariopaja@hotmail.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 3, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

evgeniy-paltsev
evgeniy-paltsev approved these changes Sep 3, 2025
View reviewed changes
Copy link
Contributor

@evgeniy-paltsev evgeniy-paltsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on STM32L431RCT6 + max98357a.

NOTE: tested TX part only on sai1_a.

@kartben kartben merged commit faf1919 into zephyrproject-rtos:main Sep 5, 2025
26 checks passed
@mariopaja mariopaja deleted the stm32l4_sai branch November 12, 2025 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evgeniy-paltsev evgeniy-paltsev evgeniy-paltsev approved these changes

@erwango erwango erwango approved these changes

@etienne-lms etienne-lms etienne-lms approved these changes

@anangl anangl Awaiting requested review from anangl

@djiatsaf-st djiatsaf-st Awaiting requested review from djiatsaf-st

@FRASTM FRASTM Awaiting requested review from FRASTM

@gautierg-st gautierg-st Awaiting requested review from gautierg-st

@GeorgeCGV GeorgeCGV Awaiting requested review from GeorgeCGV

@JarmouniA JarmouniA Awaiting requested review from JarmouniA

@kartben kartben Awaiting requested review from kartben

@marwaiehm-st marwaiehm-st Awaiting requested review from marwaiehm-st

@mathieuchopstm mathieuchopstm Awaiting requested review from mathieuchopstm

@nashif nashif Awaiting requested review from nashif

Assignees

@erwango erwango

Labels

area: I2S area: Samples Samples platform: STM32 ST Micro STM32

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@mariopaja @evgeniy-paltsev @erwango @etienne-lms @kartben @anangl @zephyrbot